Skip to content

Migrate to PureScript 0.15 #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
klntsky merged 101 commits into from
Dec 15, 2023
Merged

Migrate to PureScript 0.15 #1521

klntsky merged 101 commits into from
Dec 15, 2023

Conversation

@errfrom
Copy link
Collaborator

@errfrom errfrom commented Jun 29, 2023 •
edited by klntsky
Loading

Closes #79
Closes #1430

  1. Update purs to v0.15.8
  2. Update spago to v0.21.0
  3. Upgrade package-set
  4. Remove deprecated purescript-math dependency
  5. Remove every occurrence of using deprecated MonadZero type class
  6. Upgrade medea-ps to PureScript 0.15 Migrate to PureScript 0.15 mlabs-haskell/medea-ps#1
  7. Drop sequences dependency Drop sequences dependency mlabs-haskell/purescript-aeson#18
  8. Upgrade purescript-bignumber to PureScript 0.15 Migrate to PureScript 0.15 mlabs-haskell/purescript-bignumber#3
  9. Upgrade purescript-aeson to PureScript 0.15 Migrate to PureScript 0.15 mlabs-haskell/purescript-aeson#17
  10. Upgrade noble-secp256k1 to PureScript 0.15 Migrate to PureScript 0.15 mlabs-haskell/purescript-noble-secp256k1#3
  11. Upgrade toppokki to PureScript 0.15 Migrate to PureScript 0.15 mlabs-haskell/purescript-toppokki#1
  12. Convert cjs exports to esm using lebab, replace export var with export const
  13. Fix EncodeAeson and DecodeAeson instances for Ctl.Internal.Plutus.Types.AssocMap
  14. Remove ToMetadata instance for (NonEmpty f a) TODO: Can it be rewritten instead?
  15. Use AffjaxDriver depending on the environment (node or browser)
  16. Replace SProxy with kind-generic Proxy
  17. Fix ToData / FromData instances for Ctl.Internal.Types.Interval.Extended and Test.Data.Tree
  18. Use Test.QuickCheck.Gen.frequency with NonEmptyArray
  19. Use exists from Node.FS.Sync (Node.FS.Aff.exists has been removed)
  20. Milestone reached: CTL compiles without errors
  21. Use esm imports
  22. FIXME: Do not re-export Undefined from Contract.Prelude (remove undefined dependency from spago.dhall)
  23. Fix CIP-30 Plutip tests, use global object in Node.js environment
  24. Milestone reached: All unit and Plutip tests pass
  25. Add support for bundling using esbuild
  26. Create node_modules symlinks to NODE_PATH (see NODE_PATH is not part of resolving import specifiers)
  27. E2E tests pass (bundlePursProject now uses esbuild)
  28. Fix bundling using webpack
  29. TODO: fix and re-enable @mlabs-haskell/csl-gc-wrapper

Pre-review checklist

  • All code has been formatted using our config (make format)
  • Any new API features or modification of existing behavior is covered as defined in our test plan
  • The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Removed, ### Fixed), and the links to the appropriate issues/PRs have been included

@errfrom errfrom self-assigned this Jun 29, 2023
errfrom added 21 commits June 29, 2023 16:05
@errfrom
build: update medea and sequences deps, remove math
5d0d316
@errfrom
build: update bignumber dependency, fix flake.nix
dcc6a7c
@errfrom
build: update aeson dependency
87606c0
@errfrom
build: update noble-secp256k1 dependency
36c0ce2
@errfrom
build: update toppokki dependency
cc5dc89
@errfrom
build: use esm exports, fix aeson instances for Plutus.AssocMap
1f2f31e
@errfrom
build: select affjax driver based on environment (node or browser)
856ed1d
@errfrom
style: fix formatting
4c66024
@errfrom
build: bump purs to v0.15.8
b41ca18
@errfrom
build: fix ToData and FromData instances
8cb2766
@errfrom
build: use frequency with NonEmptyArray
43678ef
@errfrom
build: use exists from Node.FS.Sync (ctl compiles!)
389c5ce
@errfrom
build: multiple changes
3ac0f74 
1. use esm imports

2. do not re-export `Undefined` from `Contract.Prelude`

3. fix CIP-30 mock, use `global` object in Node.js environment
@errfrom
build: fix package.json, re-gen spago-packages.nix, fix formatting
6e061e1
@errfrom
chore: fix warnings
0cb50b1
@errfrom
build: fix plutip tests
ba71dfa
@errfrom
build: bundle and serve using esbuild
682badc
@errfrom
style: fix formatting
ae495bd
@errfrom
style: remove unused imports
a7799f2
@errfrom
build: use esm imports in nix/default.nix
6f2758b
@errfrom
build: use esm imports in nix/default.nix
084ca27
@errfrom errfrom force-pushed the dshuiski/purs-0.15-migration branch 2 times, most recently from c56e135 to 88d2150 Compare July 6, 2023 15:29
@errfrom errfrom force-pushed the dshuiski/purs-0.15-migration branch from 88d2150 to fe138b0 Compare July 6, 2023 15:34
@errfrom errfrom force-pushed the dshuiski/purs-0.15-migration branch from ae88ea6 to 70e3356 Compare July 6, 2023 16:03
@bladyjoker
Copy link
Contributor

bladyjoker commented Dec 11, 2023

The last remaining issue we're tracking down is https://hercules-ci.com/accounts/github/Plutonomicon/derivations/%2Fnix%2Fstore%2Ffhn3q2yjdl6jq5m0lqcfpj4ld5lyrzlz-ctl-plutip-test.drv/log?via-job=d200f417-2c25-447d-bbff-2e0de43828f3

Which is the build result of #1573

@bladyjoker bladyjoker mentioned this pull request Dec 11, 2023
Merged
@klntsky
Merge branch 'dshuiski/purs-0.15-migration' of github.com:Plutonomico…
d86035e 
…n/cardano-transaction-lib into dshuiski/purs-0.15-migration
@klarkc
Copy link

klarkc commented Dec 11, 2023 •
edited
Loading

@bladyjoker I've seen this same error in #1566, after debugging plutip cardano-node, I found an error which was being caused by a wrong cardano-api version in plutip, that's why I created mlabs-haskell/plutip#184

@brainrake
Copy link
Contributor

brainrake commented Dec 11, 2023

This is an heroic effort and I appreciate it.

@bladyjoker
Copy link
Contributor

bladyjoker commented Dec 12, 2023

@bladyjoker I've seen this same error in #1566, after debugging plutip cardano-node, I found an error which was being caused by a wrong cardano-api version in plutip, that's why I created mlabs-haskell/plutip#184

@klarkc we managed to get everything working centered around cardano-node v8.1.1.

Moving to v8.5 will have to be a battle for some other day. Can you summarize the work you did across CTL and Plutip and whether your efforts for 8.5 migration resulted in passing tests or were there some lingering issues?

@bladyjoker bladyjoker mentioned this pull request Dec 12, 2023
Merged
6 tasks
@klarkc
Copy link

klarkc commented Dec 13, 2023 •
edited
Loading

@bladyjoker I've bump cardano-api constraint to ^>= 8.25 (as in cardano-node 8.5) in order to fix request plutip errors, the last time I checked, we're being blocked by plutip -> cardano-wallet. We still need a valid build plan for plutip with cardano-wallet.

@klntsky
Copy link
Contributor

klntsky commented Dec 13, 2023

Building searchable documentation fails. Not merging yet.

@bladyjoker bladyjoker self-requested a review December 14, 2023 13:31
bladyjoker
bladyjoker approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@bladyjoker bladyjoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to click this button after all this work :)

@klarkc
Copy link

klarkc commented Dec 14, 2023

BTW, congratulations to everyone on achieving it. It will really help us here.

@klntsky klntsky mentioned this pull request Dec 15, 2023
Open
@klntsky klntsky merged commit 6a856f4 into develop Dec 15, 2023
@klntsky klntsky deleted the dshuiski/purs-0.15-migration branch December 15, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@klntsky klntsky klntsky left review comments

@bladyjoker bladyjoker bladyjoker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@klntsky klntsky

Labels

purs15

Projects

cardano-transaction-lib
Status: Done

Milestone

F10M1 Updates, tidying the codebase

Development

Successfully merging this pull request may close these issues.

Update affjax v12 to v13 Switch to esbuild

8 participants

@errfrom @bladyjoker @klntsky @klarkc @brainrake @kozross @aciceri